Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add metrics for inflight get pooled tx requests #4547

Merged
merged 1 commit into from
Sep 11, 2023
Merged

feat: add metrics for inflight get pooled tx requests #4547

merged 1 commit into from
Sep 11, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Sep 11, 2023

add new metric for active outgoing GetPooledTxs

@mattsse mattsse added the A-observability Related to tracing, metrics, logs and other observability tools label Sep 11, 2023
@codecov
Copy link

codecov bot commented Sep 11, 2023 •
edited
Loading

Codecov Report

Merging #4547 (4acee71) into main (fc9f116) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/net/network/src/metrics.rs 61.53% <ø> (ø)
crates/net/network/src/transactions.rs 60.88% <100.00%> (+0.26%) ⬆️

... and 11 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.69% <0.00%> (-0.01%) ⬇️
unit-tests 63.95% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.83% <ø> (ø)
blockchain tree 83.58% <ø> (ø)
pipeline 90.56% <ø> (ø)
storage (db) 75.32% <ø> (ø)
trie 94.88% <ø> (ø)
txpool 47.50% <ø> (ø)
networking 77.39% <100.00%> (-0.05%) ⬇️
rpc 57.37% <ø> (+<0.01%) ⬆️
consensus 63.40% <ø> (ø)
revm 31.67% <ø> (ø)
payload builder 6.34% <ø> (ø)
primitives 86.50% <ø> (-0.01%) ⬇️

@mattsse mattsse added this pull request to the merge queue Sep 11, 2023
Merged via the queue into main with commit 8cb92e3 Sep 11, 2023
24 checks passed
@mattsse mattsse deleted the matt/add-inflight-request-metrics branch September 11, 2023 11:29
@mattsse mattsse mentioned this pull request Sep 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhirin shekhirin shekhirin approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-observability Related to tracing, metrics, logs and other observability tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @shekhirin